Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proc.cpu.user_p with proc.cpu.total_p #641

Merged
merged 1 commit into from
Jan 6, 2016

Conversation

monicasarbu
Copy link
Contributor

Fixes #631

@andrewkroh
Copy link
Member

Since we have the data available to truly calculate proc.cpu.user_p I think we should calculate it so that Topbeat has both proc.cpu.user_p and proc.cpu.total_p. Then there would be no perceived loss of functional nor backwards compatibility issues with dashboards.

@andrewkroh
Copy link
Member

The changes made LGTM.

@monicasarbu
Copy link
Contributor Author

@andrewkroh Yes, indeed we can export both proc.cpu.user_p and proc.cpu.total_p, but I would prefer to have only one to be similar with what top command displays. One reason is that I am afraid that people will get confuse if topbeat exports two percentages and the top command shows only one. Another reason is that I prefer to keep the data that we export to the minimum. To fix the second concern, we could add another config option that decides when to export proc.cpu.user_p ... What are your thoughts?

@andrewkroh
Copy link
Member

Ok. I don't think I would bother with the config option. As long as we document the breaking change to the schema, users should be able to update any custom dashboards.

@dedemorton
Copy link
Contributor

@monicasarbu The screen captures in the getting started doc also need to be updated to reflect the name change: https://www.elastic.co/guide/en/beats/topbeat/current/topbeat-getting-started.html.

Should I open a doc issue to remind me to do this, or do you want to do a quick screen grab and add it yourself? I'm not sure my data will be as interesting as your data. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants